Skip to content

[codex] Allow public templates in dashboard terminal#461

Closed
matthewlouisbrockman wants to merge 1 commit into
mainfrom
codex/public-template-terminal-route
Closed

[codex] Allow public templates in dashboard terminal#461
matthewlouisbrockman wants to merge 1 commit into
mainfrom
codex/public-template-terminal-route

Conversation

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor

What changed

  • Allows owner/template references through the dashboard terminal template preflight.
  • Keeps local/default template availability checks for bare template names.
  • Adds unit coverage for public template reference detection.

Why

/sbx/new?template=owner/template worked because it calls Sandbox.create(template) directly. The dashboard terminal page rejected the same public template reference before launch because it only checked default templates and templates owned by the current team.

This made public workshop links like aiengineer-d56d/aiengineer-guide show as unavailable in the terminal UI even though the SDK could create them.

Validation

  • bunx vitest run tests/unit/dashboard-terminal.test.ts
  • bunx biome check 'src/app/dashboard/[teamSlug]/terminal/page.tsx' src/features/dashboard/terminal/template.ts tests/unit/dashboard-terminal.test.ts

@cla-bot cla-bot Bot added the cla-signed label Jun 24, 2026
@cursor

cursor Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Small change to template availability gating only; sandbox launch behavior is unchanged aside from fewer false “unavailable” states.

Overview
The dashboard terminal treated owner/template query params as unavailable because preflight only matched base, default templates, and the current team’s templates, while sandbox creation already accepted public references.

Adds isPublicTemplateReference (exactly one /, two segments) and skips the repository lookup for those refs in isTerminalTemplateAvailable. Bare names still go through the existing checks. Unit tests cover the detector.

Reviewed by Cursor Bugbot for commit bab3cf6. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 24, 2026 9:24pm
web-tango Building Building Preview, Comment Jun 24, 2026 9:24pm

Request Review

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor Author

Closing and replacing this with the correctly named Linear-task branch: overly-restrictive-template-checks-on-dashboardtabterminal-eng-4352.

@matthewlouisbrockman matthewlouisbrockman deleted the codex/public-template-terminal-route branch June 24, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant